-maxapsfee: follow-up fixes
ClosedPublic
Actions

Authored by PiRK on Sep 13 2021, 14:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC53106ad51363: -maxapsfee: follow-up fixes

Summary

Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Samuel Dobson <dobsonsa68@gmail.com>

This is a backport of core#19743

Notes:

the Release notes are not relevant because they refer to a PR that we backported almost one year ago.
the formula for computing a defaulti fee in Bitcoin ABC is 1 sat/byte * tx_size, with tx_size ~ 148 * n_in + 33 * n_out + 10. The tx sizes in the log messages checked in this PR are consistent with this formula (and different from the way Core computes the fees).

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19743

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16631
Build 33117: Build Diff	lint-circular-dependencies · build-debug · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 33116: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 13 2021, 14:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 14:22

PiRK requested review of this revision.Sep 13 2021, 14:22

teamcity edited the summary of this revision. (Show Details)Sep 13 2021, 14:23

Harbormaster completed remote builds in B16617: Diff 29904.Sep 13 2021, 14:39

PiRK edited the summary of this revision. (Show Details)Sep 13 2021, 14:44

Fabien requested changes to this revision.Sep 13 2021, 18:37

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/wallet_groups.py
24 ↗	(On Diff #29904)	Why are the values different from the original PR ?
115 ↗	(On Diff #29904)	Same question

This revision now requires changes to proceed.Sep 13 2021, 18:37

I will try to figure out exactly why the second set of values, the computed fees for the transactions created in the test, are different.

Regarding the values for the -maxapsfee parameters, it is deduced from the fees on lines 129 & 144. The difference 813 - 519 (sats) is equal to 2.94 XEC. So the 2.93XEC threshold is the limit that triggers the un-grouping of UTXOs.

I will leave a note in a comment or in the description, when I figure out how the fee is computed exactly for Bitcoin ABC. But the order of magnitude for those fee values makes sense, when I compare with similar transactions I see on the explorer.