test: Remove confusing and broken use of wait_until global
ClosedPublic
Actions

Authored by PiRK on Sep 14 2021, 13:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0128eccd0101: test: Remove confusing and broken use of wait_until global

Summary

This is a partial backport of core#19730
https://github.com/bitcoin/bitcoin/pull/19730/commits/fa330ec2fe5f5ba68a8d43fff0b19584c0b1ff39

The other commit touches only core's CI scripts.

Test Plan

test/functional/test_runner.py wallet_basic

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19730

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16641
Build 33137: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33136: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 14 2021, 13:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2021, 13:18

PiRK requested review of this revision.Sep 14 2021, 13:18

teamcity edited the summary of this revision. (Show Details)Sep 14 2021, 13:18

Harbormaster completed remote builds in B16641: Diff 29945.Sep 14 2021, 13:37

Fabien accepted this revision.Sep 15 2021, 05:48

This revision is now accepted and ready to land.Sep 15 2021, 05:48

Closed by commit rABC0128eccd0101: test: Remove confusing and broken use of wait_until global (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhySep 15 2021, 06:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0128eccd0101: test: Remove confusing and broken use of wait_until global.

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_basic.py

16 lines

Diff 29945

View Options

test/functional/wallet_basic.py

test: Remove confusing and broken use of wait_until globalClosedPublicActions