Page MenuHomePhabricator

convert amounts to XEC in RPC examples
ClosedPublic

Authored by PiRK on Oct 6 2021, 12:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa2f3ae99dbfb: convert amounts to XEC in RPC examples
Summary

RPC examples still used BCHA as a unit.

Test Plan

ninja

Print the help for a couple of command to check the output visually.
src/bitcoin-cli help fundrawtransaction

Event Timeline

PiRK requested review of this revision.Oct 6 2021, 12:35

Tail of the build log:

[389/448] Running utility command for check-bitcoin-finalization_tests
[390/448] bitcoin: testing merkleblock_tests
[391/448] bitcoin: testing transaction_tests
[392/448] Running utility command for check-bitcoin-scheduler_tests
[393/448] bitcoin: testing bip32_tests
[394/448] Running utility command for check-bitcoin-merkleblock_tests
[395/448] Running utility command for check-bitcoin-transaction_tests
[396/448] Running utility command for check-bitcoin-bip32_tests
[397/448] bitcoin: testing sync_tests
[398/448] bitcoin: testing torcontrol_tests
[399/448] Running utility command for check-bitcoin-sync_tests
[400/448] Running utility command for check-bitcoin-torcontrol_tests
[401/448] bitcoin: testing settings_tests
[402/448] Running utility command for check-bitcoin-settings_tests
[403/448] bitcoin: testing streams_tests
[404/448] bitcoin: testing timedata_tests
[405/448] bitcoin: testing validation_flush_tests
[406/448] Running utility command for check-bitcoin-streams_tests
[407/448] Running utility command for check-bitcoin-validation_flush_tests
[408/448] Running utility command for check-bitcoin-timedata_tests
[409/448] bitcoin: testing compilerbug_tests
[410/448] Running utility command for check-bitcoin-compilerbug_tests
[411/448] bitcoin: testing checkpoints_tests
[412/448] bitcoin: testing txvalidationcache_tests
[413/448] Running utility command for check-bitcoin-checkpoints_tests
[414/448] Running utility command for check-bitcoin-txvalidationcache_tests
[415/448] bitcoin: testing serialize_tests
[416/448] bitcoin: testing validationinterface_tests
[417/448] Running utility command for check-bitcoin-serialize_tests
[418/448] Running utility command for check-bitcoin-validationinterface_tests
[419/448] bitcoin: testing script_standard_tests
[420/448] bitcoin: testing radix_tests
[421/448] Running utility command for check-bitcoin-script_standard_tests
[422/448] bitcoin: testing intmath_tests
[423/448] Running utility command for check-bitcoin-radix_tests
[424/448] Running utility command for check-bitcoin-intmath_tests
[425/448] bitcoin: testing schnorr_tests
[426/448] bitcoin: testing blockstatus_tests
[427/448] Running utility command for check-bitcoin-schnorr_tests
[428/448] bitcoin: testing cashaddr_tests
[429/448] Running utility command for check-bitcoin-blockstatus_tests
[430/448] Running utility command for check-bitcoin-cashaddr_tests
[431/448] bitcoin: testing util_tests
[432/448] Running utility command for check-bitcoin-util_tests
[433/448] bitcoin: testing script_tests
[434/448] Running utility command for check-bitcoin-script_tests
[435/448] bitcoin: testing crypto_tests
[436/448] Running utility command for check-bitcoin-crypto_tests
[437/448] bitcoin: testing coinselector_tests
[438/448] Running utility command for check-bitcoin-coinselector_tests
[439/448] bitcoin: testing monolith_opcodes_tests
[440/448] bitcoin: testing versionbits_tests
[441/448] Running utility command for check-bitcoin-monolith_opcodes_tests
[442/448] Running utility command for check-bitcoin-versionbits_tests
[443/448] bitcoin: testing blockcheck_tests
[444/448] Running utility command for check-bitcoin-blockcheck_tests
[445/448] bitcoin: testing coins_tests
[446/448] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Unrelated failure

[12:43:48]
[Step 1/1] FAILED: src/test/CMakeFiles/check-bitcoin-wallet_tests
[12:43:48]
[Step 1/1] cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-wallet_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_tests.xml --catch_system_errors=no
[12:43:48]
[Step 1/1] Segmentation fault (core dumped)
This revision is now accepted and ready to land.Oct 6 2021, 15:00
This revision was landed with ongoing or failed builds.Oct 6 2021, 16:34
This revision was automatically updated to reflect the committed changes.