[Cashtab] Rebranding Token menu/button labels into eToken
ClosedPublic
Actions

Authored by emack on Oct 10 2021, 00:08.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCf3ea606b06a3: [Cashtab] Rebranding Token menu/button labels into eToken

Summary

Rebranded 'Token' labels into 'eToken' across:

Wallet.js - Wallet screen transaction history menu
components/App.js - Main menu on bottom of web UI
extension/App.js - Main menu on bottom of extension UI
CreateTokenForm.js - Tokens menu and the subsequent token creation screen
UI Snapshots updated across Tokens and CreateTokenForm

Test Plan

npm start
Click on the Wallet section and check the eTokens tab is displayed next to Transaction History, then switch to Transaction History and back to eTokens
Click on the 'eTokens' section on the bottom menu and ensure the initial 'Create eToken' label is displayed correctly
Click on the 'Create eToken' button and ensure the final creation button at the bottom of the screen is 'Create eToken'
npm run extension
Repeat 1-4 in browser extension mode

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rebrand-branch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17043
Build 33919: Build Diff	cashtab-tests
Build 33918: arc lint + arc unit

Event Timeline

emack created this revision.Oct 10 2021, 00:08

Owners added a reviewer: Restricted Owners Package.Oct 10 2021, 00:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2021, 00:08

emack requested review of this revision.Oct 10 2021, 00:08

Harbormaster completed remote builds in B16949: Diff 30399.Oct 10 2021, 00:12

Nice! Thanks for working through + discovering the prettier issue.

One small change -- this has made the length of the tab label on the Wallet Screen slightly longer, so it throws off the underline-moving rendering:

Please make the necessary edits to the TabLine styled component on Line 43. Takes some guess and checking + testing to line it up properly.

This revision now requires changes to proceed.Oct 12 2021, 20:34

Adjusted TabLine styled component in Wallet.js to fix the underline-moving rendering issue. Tested all ok in both web and browser extension mode, as well as via manual resizing of browser width.