Differential D10356

[avalanche] Make ProofRef a shared pointer to a const proof
ClosedPublic
Actions

Authored by Fabien on Oct 15 2021, 07:52.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCbb66fe58adb4: [avalanche] Make ProofRef a shared pointer to a const proof

Summary

This requires an update of the processor factory method.

Ref T1854.

Depends on D10342.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proofref_const

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17046
Build 33925: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33924: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 15 2021, 07:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2021, 07:52

Fabien requested review of this revision.Oct 15 2021, 07:52

Fabien mentioned this in D10342: [avalanche] Introduce ProofRef as an alias for std::shared_ptr<Proof>.Oct 15 2021, 07:53

Harbormaster completed remote builds in B17046: Diff 30572.Oct 15 2021, 08:10

deadalnix accepted this revision.Oct 15 2021, 11:41

This revision is now accepted and ready to land.Oct 15 2021, 11:41

Closed by commit rABCbb66fe58adb4: [avalanche] Make ProofRef a shared pointer to a const proof (authored by Fabien). · Explain WhyOct 15 2021, 11:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbb66fe58adb4: [avalanche] Make ProofRef a shared pointer to a const proof.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

6 lines

proof.h

2 lines

Diff 30572

View Options

src/avalanche/processor.cpp