Differential D10389

[avalanche] Make the proof builders build a ProofRef
ClosedPublic
Actions

Authored by Fabien on Oct 26 2021, 08:48.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC794d849dda3b: [avalanche] Make the proof builders build a ProofRef

Summary

This removes some boilerplate in the code, especially in the tests.
Updated the proof builder and test builder failities to keep the code consistent.

Ref T1854.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proofbuilder_proofref

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17115
Build 34062: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-clang · build-diff
Build 34061: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 26 2021, 08:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2021, 08:48

Fabien requested review of this revision.Oct 26 2021, 08:48

Harbormaster completed remote builds in B17115: Diff 30661.Oct 26 2021, 09:03

deadalnix accepted this revision.Oct 26 2021, 21:06

This revision is now accepted and ready to land.Oct 26 2021, 21:06

Closed by commit rABC794d849dda3b: [avalanche] Make the proof builders build a ProofRef (authored by Fabien). · Explain WhyOct 27 2021, 07:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC794d849dda3b: [avalanche] Make the proof builders build a ProofRef.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proofbuilder.h

2 lines

proofbuilder.cpp

8 lines

test/

orphanproofpool_tests.cpp

2 lines

peermanager_tests.cpp

14 lines

2 lines

40 lines

4 lines

16 lines

rpc/

avalanche.cpp

4 lines

Diff 30661

View Options

src/avalanche/proofbuilder.h

View Options

src/avalanche/proofbuilder.cpp

View Options

src/avalanche/test/orphanproofpool_tests.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/avalanche/test/proof_tests.cpp

View Options

src/avalanche/test/util.h

View Options

src/avalanche/test/util.cpp

View Options

[avalanche] Make the proof builders build a ProofRefClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30661

src/avalanche/proofbuilder.h

src/avalanche/proofbuilder.cpp

src/avalanche/test/orphanproofpool_tests.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/processor_tests.cpp

src/avalanche/test/proof_tests.cpp

src/avalanche/test/util.h

src/avalanche/test/util.cpp

src/rpc/avalanche.cpp

[avalanche] Make the proof builders build a ProofRef
ClosedPublic
Actions

Revision Contents
Changeset List