Page MenuHomePhabricator

Support NODE_NETWORK_LIMITED filtering by default
ClosedPublic

Authored by thonkle on Oct 26 2021, 18:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC924e2afc6c2e: Support NODE_NETWORK_LIMITED filtering by default
Summary

The seeder supports subdomaining by a whitelist filter according to node service flags.
This patch adds NODE_NETWORK_LIMITED to that whitelist by default.

Backport of this commit: https://github.com/sipa/bitcoin-seeder/commit/002bc0bbd5bfd721d7c80d7cdd35a47165f7c1ff

Test Plan

Run the seeder until it has hundreds or thousands of nodes crawled:

./src/seeder/bitcoin-seeder -host=seeder.status.cash -ns=localhost -mbox=thonkle@protonmail.com -port=5555

Each subdomain should return results according to the filter:
NODE_NETWORK:

dig +noall +answer @:: -p 5555 x1.seeder.status.cash

NODE_NETWORK | NODE_BLOOM:

dig +noall +answer @:: -p 5555 x5.seeder.status.cash

NODE_NETWORK_LIMITED:

dig +noall +answer @:: -p 5555 x400.seeder.status.cash

NODE_NETWORK_LIMITED | NODE_BLOOM:

dig +noall +answer @:: -p 5555 x404.seeder.status.cash

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 26 2021, 18:25
thonkle requested review of this revision.Oct 26 2021, 18:25
deadalnix requested changes to this revision.Oct 26 2021, 21:49
deadalnix added a subscriber: deadalnix.

Please send a link to the PR itself so we can see the discussion and associated code.

This revision now requires changes to proceed.Oct 26 2021, 21:49
thonkle requested review of this revision.Oct 26 2021, 21:54

Please send a link to the PR itself so we can see the discussion and associated code.

There is no PR. sipa pushed the commit without review

This revision is now accepted and ready to land.Nov 26 2021, 16:50