Page MenuHomePhabricator
Differential D10424

[Cashtab] add latest commit hash to configure.js
AbandonedPublic
Actions

Authored by kieran709 on Nov 2 2021, 15:10.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Added latest commit hash to the footer of the configure.js component, links to latest commit on github. Related to task T1760.

Test Plan

ensure cashtab is rebased with latest version of master
cd web/cashtab
npm start
in separate terminal run git rev-parse HEAD
take note of latest commit hash
ensure link on configure page matches latest commit hash

Diff Detail

Repository
rABC Bitcoin ABC
Branch
auto-add-latest-commit-hash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17181
Build 34193: Build Diffcashtab-tests
Build 34192: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 2 2021, 15:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2021, 15:10
kieran709 requested review of this revision.Nov 2 2021, 15:10
Harbormaster completed remote builds in B17169: Diff 30739.Nov 2 2021, 15:13
teamcity added a comment.Nov 2 2021, 15:13
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  -  0
+ Received  + 16

@@ -275,6 +275,22 @@
      type="link"
    >
      Documentation
    </a>
    ]
+   <br />
+   <div
+     className="sc-hSdWYo kDMVEG"
+   >
+     <p
+       className="sc-eHgmQL gPThIU"
+     >
+       Latest Commit:
+       <br />
+       <a
+         className="sc-dxgOiQ jbuVAx"
+         href="https://github.com/Bitcoin-ABC/bitcoin-abc/commit/undefined"
+         type="link"
+       />
+     </p>
+   </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  -  0
+ Received  + 16

@@ -313,6 +313,22 @@
      type="link"
    >
      Documentation
    </a>
    ]
+   <br />
+   <div
+     className="sc-hSdWYo kDMVEG"
+   >
+     <p
+       className="sc-eHgmQL gPThIU"
+     >
+       Latest Commit:
+       <br />
+       <a
+         className="sc-dxgOiQ jbuVAx"
+         href="https://github.com/Bitcoin-ABC/bitcoin-abc/commit/undefined"
+         type="link"
+       />
+     </p>
+   </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30742.Nov 2 2021, 15:17

update snapshots

kieran709 planned changes to this revision.Nov 2 2021, 15:18

Currently the latest commit hash read by running git rev-parse HEAD leads to a 404 on github, changes needed prior to review.

Harbormaster completed remote builds in B17172: Diff 30742.Nov 2 2021, 15:28
kieran709 updated this revision to Diff 30747.Nov 2 2021, 16:32

Responding to feedback, hash displayed in footer now links to https://reviews.bitcoinabc.org

bytesofman requested changes to this revision.Nov 2 2021, 16:40

Looks good. A couple of minor changes.

  • Only display the first 9 characters of the commit hash
  • Change text "Latest Commit:" to "Source: "

Hopefully these changes get it to be on the same line. If not, display fewer characters, as few as 9.

This revision now requires changes to proceed.Nov 2 2021, 16:40
Harbormaster completed remote builds in B17175: Diff 30747.Nov 2 2021, 16:43
teamcity added a comment.Nov 2 2021, 16:43
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -286,11 +286,11 @@
      >
        Latest Commit:
        <br />
        <a
          className="sc-dxgOiQ jbuVAx"
-         href="https://github.com/Bitcoin-ABC/bitcoin-abc/commit/undefined"
+         href="https://reviews.bitcoinabc.org/"
          type="link"
        />
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -324,11 +324,11 @@
      >
        Latest Commit:
        <br />
        <a
          className="sc-dxgOiQ jbuVAx"
-         href="https://github.com/Bitcoin-ABC/bitcoin-abc/commit/undefined"
+         href="https://reviews.bitcoinabc.org/"
          type="link"
        />
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30749.Nov 2 2021, 16:47

responding to review feedback

Harbormaster completed remote builds in B17177: Diff 30749.Nov 2 2021, 16:50
teamcity added a comment.Nov 2 2021, 16:50
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
TypeError: Cannot read property 'slice' of undefined
    at Configure (/work/web/cashtab/src/components/Configure/Configure.js:695:56)
    at renderWithHooks (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
    at mountIndeterminateComponent (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
    at beginWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
    at performUnitOfWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
    at workLoopSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
    at renderRootSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
    at performSyncWorkOnRoot (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
    at /work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26
    at unstable_runWithPriority (/work/web/cashtab/node_modules/scheduler/cjs/scheduler.development.js:646:12)
    at runWithPriority (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
    at flushSyncCallbackQueueImpl (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
    at flushSyncCallbackQueue (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
    at scheduleUpdateOnFiber (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
    at updateContainer (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:16454:3)
    at Object.create (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:17149:3)
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:18:32)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
TypeError: Cannot read property 'slice' of undefined
    at Configure (/work/web/cashtab/src/components/Configure/Configure.js:695:56)
    at renderWithHooks (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
    at mountIndeterminateComponent (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
    at beginWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
    at performUnitOfWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
    at workLoopSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
    at renderRootSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
    at performSyncWorkOnRoot (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
    at /work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26
    at unstable_runWithPriority (/work/web/cashtab/node_modules/scheduler/cjs/scheduler.development.js:646:12)
    at runWithPriority (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
    at flushSyncCallbackQueueImpl (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
    at flushSyncCallbackQueue (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
    at scheduleUpdateOnFiber (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
    at updateContainer (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:16454:3)
    at Object.create (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:17149:3)
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:29:32)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

bytesofman requested changes to this revision.Nov 2 2021, 16:55

Run npm test before pushing up the amended diff to make sure it will pass teamcity; also can debug with the error log info from npm test

This revision now requires changes to proceed.Nov 2 2021, 16:55
kieran709 updated this revision to Diff 30751.Nov 2 2021, 17:17

responding to review feedback, fixed testing error

Harbormaster completed remote builds in B17179: Diff 30751.Nov 2 2021, 17:21
teamcity added a comment.Nov 2 2021, 17:21
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -289,10 +289,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         2078cb854
+         21902c8e8
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -327,10 +327,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         2078cb854
+         21902c8e8
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30752.Nov 2 2021, 17:22

responding to feedback

kieran709 updated this revision to Diff 30753.Nov 2 2021, 17:25

update snapshots

Harbormaster completed remote builds in B17180: Diff 30752.Nov 2 2021, 17:26
teamcity added a comment.Nov 2 2021, 17:26
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 2
+ Received  + 1

@@ -283,16 +283,15 @@
    >
      <p
        className="sc-eHgmQL gPThIU"
      >
        Source:
-       <br />
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         2078cb854
+         4b0345d45
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 2
+ Received  + 1

@@ -321,16 +321,15 @@
    >
      <p
        className="sc-eHgmQL gPThIU"
      >
        Source:
-       <br />
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         2078cb854
+         4b0345d45
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

Harbormaster completed remote builds in B17181: Diff 30753.Nov 2 2021, 17:28
teamcity added a comment.Nov 2 2021, 17:28
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -288,10 +288,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         4b0345d45
+         2f0545500
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -326,10 +326,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         4b0345d45
+         2f0545500
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30754.Nov 2 2021, 18:14

rebasing, further work still needed to pass tests.

kieran709 planned changes to this revision.Nov 2 2021, 18:16

2 snapshots fail each time REACT_APP_VERSION changes, working on solution.

Harbormaster completed remote builds in B17182: Diff 30754.Nov 2 2021, 18:17
teamcity added a comment.Nov 2 2021, 18:17
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -288,10 +288,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         4b0345d45
+         f1a259ab5
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -326,10 +326,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         4b0345d45
+         f1a259ab5
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30776.Nov 3 2021, 14:27

committing to test snapshot solution

kieran709 planned changes to this revision.Nov 3 2021, 14:28

Still working on snapshot issue.

Harbormaster completed remote builds in B17187: Diff 30776.Nov 3 2021, 14:30
teamcity added a comment.Nov 3 2021, 14:30
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -288,10 +288,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         f1a259ab5
+         abf54764c
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -326,10 +326,10 @@
        <a
          className="sc-dxgOiQ jbuVAx"
          href="https://reviews.bitcoinabc.org/"
          type="link"
        >
-         f1a259ab5
+         abf54764c
        </a>
      </p>
    </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 30777.Nov 3 2021, 17:17

updated method of serving latest commit hash to pass snapshot test

Harbormaster completed remote builds in B17188: Diff 30777.Nov 3 2021, 17:20
kieran709 abandoned this revision.Nov 4 2021, 20:46

new diff incoming due issue with rebasing.

Revision Contents
Changeset List

PathSize
web/
cashtab/
6 lines
src/
components/
Configure/
23 lines
__tests__/
__snapshots__/

Diff 30753

View Options

web/cashtab/package.json

Loading...
View Options

web/cashtab/src/components/Configure/Configure.js

Loading...
View Options

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...