[tests] Replace bytes literals with hex literals
ClosedPublic
Actions

Authored by PiRK on Nov 2 2021, 11:04.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC214964805261: [tests] Replace bytes literals with hex literals

Summary

It's almost impossible to read bytes literals in code, so replace them
with the hex string literal and then convert them to a bytes object
using bytes.fromhex().

This is a backport of core#19253 [2/2]
https://github.com/bitcoin/bitcoin/pull/19253/commits/825fcae484f31182041dfacbf820e818d759b130

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 2 2021, 11:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2021, 11:04

PiRK requested review of this revision.Nov 2 2021, 11:04

teamcity edited the summary of this revision. (Show Details)Nov 2 2021, 11:06

Harbormaster completed remote builds in B17162: Diff 30732.Nov 2 2021, 11:43

majcosta accepted this revision.Nov 2 2021, 19:19

This revision is now accepted and ready to land.Nov 2 2021, 19:19

Closed by commit rABC214964805261: [tests] Replace bytes literals with hex literals (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyNov 3 2021, 07:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC214964805261: [tests] Replace bytes literals with hex literals.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

address.py

29 lines

Diff 30766

View Options

test/functional/test_framework/address.py

[tests] Replace bytes literals with hex literalsClosedPublicActions