Page MenuHomePhabricator

net, refactor: Move AddLocal call one level up
ClosedPublic

Authored by PiRK on Nov 9 2021, 17:06.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCa83f882a3edd: net, refactor: Move AddLocal call one level up
Summary

This change simplifies the following commit.

This is a backport of core#19991 [6/8]
https://github.com/bitcoin/bitcoin/pull/19991/commits/92bd3c1da48d17c8ba20349e18ad19051614bc1a

Depends on D10448

Test Plan

ninja all check-all

Event Timeline

Tail of the build log:

[391/448] Running utility command for check-bitcoin-sync_tests
[392/448] Running utility command for check-bitcoin-torcontrol_tests
[393/448] bitcoin: testing txvalidationcache_tests
[394/448] Running utility command for check-bitcoin-txvalidationcache_tests
[395/448] bitcoin: testing settings_tests
[396/448] Running utility command for check-bitcoin-settings_tests
[397/448] bitcoin: testing streams_tests
[398/448] Running utility command for check-bitcoin-streams_tests
[399/448] bitcoin: testing timedata_tests
[400/448] bitcoin: testing validation_flush_tests
[401/448] Running utility command for check-bitcoin-timedata_tests
[402/448] bitcoin: testing cuckoocache_tests
[403/448] Running utility command for check-bitcoin-validation_flush_tests
[404/448] Running utility command for check-bitcoin-cuckoocache_tests
[405/448] bitcoin: testing serialize_tests
[406/448] bitcoin: testing op_reversebytes_tests
[407/448] bitcoin: testing compilerbug_tests
[408/448] Running utility command for check-bitcoin-compilerbug_tests
[409/448] bitcoin: testing radix_tests
[410/448] bitcoin: testing checkpoints_tests
[411/448] Running utility command for check-bitcoin-serialize_tests
[412/448] Running utility command for check-bitcoin-op_reversebytes_tests
[413/448] Running utility command for check-bitcoin-radix_tests
[414/448] Running utility command for check-bitcoin-checkpoints_tests
[415/448] bitcoin: testing transaction_tests
[416/448] bitcoin: testing blockcheck_tests
[417/448] Running utility command for check-pow-aserti32d_tests
[418/448] Running pow test suite
PASSED: pow test suite
[419/448] Running utility command for check-bitcoin-transaction_tests
[420/448] bitcoin: testing validationinterface_tests
[421/448] Running utility command for check-bitcoin-blockcheck_tests
[422/448] bitcoin: testing schnorr_tests
[423/448] Running utility command for check-bitcoin-validationinterface_tests
[424/448] Running utility command for check-bitcoin-schnorr_tests
[425/448] bitcoin: testing script_standard_tests
[426/448] bitcoin: testing cashaddr_tests
[427/448] Running utility command for check-bitcoin-script_standard_tests
[428/448] Running utility command for check-bitcoin-cashaddr_tests
[429/448] bitcoin: testing script_tests
[430/448] bitcoin: testing intmath_tests
[431/448] Running utility command for check-bitcoin-script_tests
[432/448] Running utility command for check-bitcoin-intmath_tests
[433/448] bitcoin: testing versionbits_tests
[434/448] Running utility command for check-bitcoin-versionbits_tests
[435/448] bitcoin: testing crypto_tests
[436/448] Running utility command for check-bitcoin-crypto_tests
[437/448] bitcoin: testing monolith_opcodes_tests
[438/448] Running utility command for check-bitcoin-monolith_opcodes_tests
[439/448] bitcoin: testing coinselector_tests
[440/448] Running utility command for check-bitcoin-coinselector_tests
[441/448] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[442/448] Linking CXX executable src/qt/test/test_bitcoin-qt
[443/448] bitcoin-qt: testing test_bitcoin-qt
[444/448] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[445/448] bitcoin: testing coins_tests
[446/448] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
majcosta added a subscriber: majcosta.

tested ok locally, clang-tidy being flaky

This revision is now accepted and ready to land.Nov 10 2021, 06:46

tested ok locally, clang-tidy being flaky

Thanks. The flaky test is possibly related to D10196. We have suspicions for what causes the issue, but I have not yet been able to consistently reproduce the issue.

This revision was landed with ongoing or failed builds.Nov 10 2021, 08:58
This revision was automatically updated to reflect the committed changes.