Differential D10480

[Cashtab] Add transparent padding to eCash logo
ClosedPublic
Actions

Authored by emack on Nov 17 2021, 11:18.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC512a13f0e407: [Cashtab] Add transparent padding to eCash logo

Summary

As noted by @Klakurka in T1961, the eCash logo in prod has a small portion of the left and right edges cut off. This diff adds extra transaprent padding to both sides of the logo.

Test Plan

npm start
cycle through the Wallet, eToken, Send and Setting menus and ensure top right eCash logo is displayed correctly
manual resizing of browser width to ensure it is dynamically resized and look ok
cross browser check in firefox
this logo is not shown in extension mode, no testing needed there

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-logofix

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 17267
Build 34362: Build Diff	cashtab-tests
Build 34361: arc lint + arc unit

Event Timeline

emack created this revision.Nov 17 2021, 11:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2021, 11:18

emack requested review of this revision.Nov 17 2021, 11:18

Harbormaster completed remote builds in B17267: Diff 30889.Nov 17 2021, 11:21

bytesofman accepted this revision.Nov 17 2021, 19:39

This revision is now accepted and ready to land.Nov 17 2021, 19:39

Closed by commit rABC512a13f0e407: [Cashtab] Add transparent padding to eCash logo (authored by emack). · Explain WhyNov 17 2021, 23:46

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC512a13f0e407: [Cashtab] Add transparent padding to eCash logo.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

assets/

logo_topright.png

Diff 30889

web/cashtab/src/assets/logo_topright.png

Loading...