Differential D10489

[Cashtab] Fix DOM warnings in browser console for message signing properties
ClosedPublic
Actions

Authored by emack on Nov 18 2021, 21:35.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC89dffd8966b3: [Cashtab] Fix DOM warnings in browser console for message signing properties

Summary

Corrected TextArea property for Address and Signature

Test Plan

npm start
Display browser dev console
Navigate to Send page and uncollapse the Sign Message section and ensure the above warning is no longer present
Ensure Sign message function has not regressed
Cross check in firefox

Diff Detail

Repository

rABC Bitcoin ABC

Branch

dom-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17287
Build 34402: Build Diff	cashtab-tests
Build 34401: arc lint + arc unit

Event Timeline

emack created this revision.Nov 18 2021, 21:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2021, 21:35

emack requested review of this revision.Nov 18 2021, 21:35

emack edited the summary of this revision. (Show Details)Nov 18 2021, 21:35

bytesofman accepted this revision.Nov 18 2021, 21:41

This revision is now accepted and ready to land.Nov 18 2021, 21:41

Harbormaster completed remote builds in B17287: Diff 30918.Nov 18 2021, 21:42

Closed by commit rABC89dffd8966b3: [Cashtab] Fix DOM warnings in browser console for message signing properties (authored by emack). · Explain WhyNov 18 2021, 21:56

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC89dffd8966b3: [Cashtab] Fix DOM warnings in browser console for message signing properties.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Send/

Send.js

4 lines

Diff 30918

View Options

web/cashtab/src/components/Send/Send.js

[Cashtab] Fix DOM warnings in browser console for message signing propertiesClosedPublicActions