Page MenuHomePhabricator
Differential D10496

[Cashtab] Enhance message display UI
ClosedPublic
Actions

Authored by emack on Nov 22 2021, 11:21.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCe39a4ac6f7ac: [Cashtab] Enhance message display UI
Summary
  • Re-position the UI elements within the TxWrapper to maximize legibility of the OP_RETURN message and avoid overflows with Transaction properties seen in T1974.
  • Verified across web view, mobile view and extension view.
  • Adjusted message input placeholder text as per T1972.

1 web.PNG (772×603 px, 186 KB)

2. mobile.jpg (930×421 px, 132 KB)

3. extension view.PNG (707×511 px, 67 KB)

Test Plan
  • npm start
  • test with messages that have long words, short words, one liners...etc and ensure the message is displayed as per screenshots below.
  • test with a message containing 150 consecutive characters of unbroken X (i.e. xxxxxxxxxxxxxxxxx...) and ensure message is contained within the TxWrapper UI.
  • npm run extension.
  • ensure same UI displays in extension mode.
  • ensure same UI displays in firefox.
  • use mobile phone to access the local Cashtab instance via bridged adapter and ensure same UI displays in actual mobile view.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
2 lines
__tests__/
__snapshots__/
Wallet/
41 lines
__tests__/
__snapshots__/

Diff 30937

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...
View Options

web/cashtab/src/components/Wallet/Tx.js

Loading...
View Options

web/cashtab/src/components/Wallet/__tests__/__snapshots__/Wallet.test.js.snap

Loading...