test: Remove unused nVersion=1 in p2p tests
ClosedPublic
Actions

Authored by PiRK on Nov 23 2021, 10:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9b3b6c902490: test: Remove unused nVersion=1 in p2p tests

Summary

After D9195 nVersion is no longer used in p2p logic when sending messages. Only when receiving
messages, but in this test no messages are received.

This is a backport of core#20131

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20131

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17304
Build 34436: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 34435: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 23 2021, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2021, 10:18

PiRK requested review of this revision.Nov 23 2021, 10:18

teamcity edited the summary of this revision. (Show Details)Nov 23 2021, 10:18

Harbormaster completed remote builds in B17304: Diff 30940.Nov 23 2021, 10:32

Fabien accepted this revision.Nov 23 2021, 14:09

This revision is now accepted and ready to land.Nov 23 2021, 14:09

Closed by commit rABC9b3b6c902490: test: Remove unused nVersion=1 in p2p tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 23 2021, 16:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9b3b6c902490: test: Remove unused nVersion=1 in p2p tests.

Revision Contents
Changeset List

Path

Size

src/

test/

denialofservice_tests.cpp

5 lines

Diff 30940

View Options

src/test/denialofservice_tests.cpp

test: Remove unused nVersion=1 in p2p testsClosedPublicActions