Differential D10556

[avalanche] Simplify the proof verification code in the peer manager
ClosedPublic
Actions

Authored by Fabien on Nov 26 2021, 09:53.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC1612135f568a: [avalanche] Simplify the proof verification code in the peer manager

Summary

As per review https://reviews.bitcoinabc.org/D10522#inline-49160, there is no point passing the state as a parameter if it is already captured. This makes it possible to simplify the code a bit.

Ref T1854.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 26 2021, 09:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 09:53

Fabien requested review of this revision.Nov 26 2021, 09:53

Harbormaster completed remote builds in B17388: Diff 31063.Nov 26 2021, 10:04

deadalnix accepted this revision.Nov 26 2021, 14:12

This revision is now accepted and ready to land.Nov 26 2021, 14:12

Closed by commit rABC1612135f568a: [avalanche] Simplify the proof verification code in the peer manager (authored by Fabien). · Explain WhyNov 26 2021, 15:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1612135f568a: [avalanche] Simplify the proof verification code in the peer manager.

Fabien mentioned this in D10522: [avalanche] Add wrappers to add and remove a proof from a proof pool.Nov 27 2021, 00:12

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

10 lines

Diff 31096

View Options

src/avalanche/peermanager.cpp

[avalanche] Simplify the proof verification code in the peer managerClosedPublicActions