Differential D10581

[Cashtab] Add support for New Taiwan Dollar
ClosedPublic
Actions

Authored by kieran709 on Nov 26 2021, 20:34.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC2e13fabbd571: [Cashtab] Add support for New Taiwan Dollar

Summary

Added support for New Taiwan Dollar. Related to task T2012.

Test Plan

npm start
cd web/cashtab
navigate to configure page
select New Taiwan Dollar in the Fiat Currency dropdown
ensure fiat is set to New Taiwan Dollar & that conversion is taking place

Diff Detail

Repository

rABC Bitcoin ABC

Branch

support-new-taiwan-dollar

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17419
Build 34666: Build Diff	cashtab-tests
Build 34665: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 26 2021, 20:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 20:34

kieran709 requested review of this revision.Nov 26 2021, 20:34

Harbormaster completed remote builds in B17419: Diff 31113.Nov 26 2021, 20:37

Please rebase before landing

This revision is now accepted and ready to land.Nov 29 2021, 20:32

rebasing per review feedback

Harbormaster completed remote builds in B17449: Diff 31153.Nov 29 2021, 20:39

Closed by commit rABC2e13fabbd571: [Cashtab] Add support for New Taiwan Dollar (authored by kieran709). · Explain WhyNov 29 2021, 20:50

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC2e13fabbd571: [Cashtab] Add support for New Taiwan Dollar.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

Ticker.js

2 lines

Diff 31113

View Options

web/cashtab/src/components/Common/Ticker.js

[Cashtab] Add support for New Taiwan DollarClosedPublicActions