Page MenuHomePhabricator

[Cashtab] Instructions for adding icon to pre-existing token
ClosedPublic

Authored by kieran709 on Nov 24 2021, 18:45.

Details

Summary

Added instructions for token icon creation for already created tokens. Related to task T1982.

Test Plan

cd web/casthab
npm start
navigate to token page, ensure alert is present and that copy is sufficient.
navigate to send token page, ensure alert is present and that copy is sufficient.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-icon-instruction
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17421
Build 34670: Build Diffcashtab-tests
Build 34669: arc lint + arc unit

Event Timeline

This diff is good to go -- but see inline comment. Please create task + separate diff for that issue. We'll land that first, then rebase this to fix the @generated snapshot issue.

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap
1 ↗(On Diff #30999)

missing @generated -- mb this script should be "posttest" instead of "pretest." I think what's happening for updated snapshots -- it adds "@generated" before the test, but then updates the snapshots afterward...so no prefix.

Please create a task to make this change + take it on. thanks!

This revision now requires changes to proceed.Nov 26 2021, 03:37

responding to review feedback

bytesofman added inline comments.
web/cashtab/src/components/Send/SendToken.js
241 ↗(On Diff #31112)

Because this component is re-used, please create it under Components/Common, then import it into these 2 pages.

We might want to have various alerts like this in the future...so I think okay to create a new file, say Alerts.js Export it from there.

This revision now requires changes to proceed.Nov 26 2021, 19:05

responding to review feedback

Failed tests logs:

====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 37
+ Received  + 39

@@ -4,52 +4,54 @@
    >
      6.001
       
      TBS
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-row"
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/SendToken.test.js:76:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 37
+ Received  + 39

@@ -12,52 +12,54 @@
      $ 
      NaN
       
      USD
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-collapse ant-collapse-icon-position-left sc-gqjmRU fLjHet"
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:96:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 37
+ Received  + 39

@@ -11,52 +11,54 @@
    >
      0
       
      XEC
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-collapse ant-collapse-icon-position-left sc-gqjmRU eryBsW"
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:54:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 37
+ Received  + 39

@@ -11,52 +11,54 @@
    >
      0
       
      XEC
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-collapse ant-collapse-icon-position-left sc-gqjmRU eryBsW"
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:68:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 37
+ Received  + 39

@@ -11,52 +11,54 @@
    >
      0
       
      XEC
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-collapse ant-collapse-icon-position-left sc-gqjmRU eryBsW"
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:82:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 37
+ Received  + 39

@@ -11,52 +11,54 @@
    >
      0
       
      XEC
    </div>,
-   <div
-     className="ant-alert ant-alert-warning ant-alert-with-description"
-     data-show={true}
-     role="alert"
-     style={
-       Object {
-         "marginBottom": "12px",
+   <div>
+     <div
+       className="ant-alert ant-alert-warning ant-alert-with-description"
+       data-show={true}
+       role="alert"
+       style={
+         Object {
+           "marginBottom": "12px",
+         }
        }
-     }
-   >
-     <span
-       aria-label="exclamation-circle"
-       className="anticon anticon-exclamation-circle ant-alert-icon"
-       role="img"
      >
-       <svg
-         aria-hidden="true"
-         data-icon="exclamation-circle"
-         fill="currentColor"
-         focusable="false"
-         height="1em"
-         viewBox="64 64 896 896"
-         width="1em"
+       <span
+         aria-label="exclamation-circle"
+         className="anticon anticon-exclamation-circle ant-alert-icon"
+         role="img"
        >
-         <path
-           d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
-         />
-         <path
-           d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
-         />
-       </svg>
-     </span>
-     <div
-       className="ant-alert-content"
-     >
+         <svg
+           aria-hidden="true"
+           data-icon="exclamation-circle"
+           fill="currentColor"
+           focusable="false"
+           height="1em"
+           viewBox="64 64 896 896"
+           width="1em"
+         >
+           <path
+             d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z"
+           />
+           <path
+             d="M464 688a48 48 0 1096 0 48 48 0 10-96 0zm24-112h48c4.4 0 8-3.6 8-8V296c0-4.4-3.6-8-8-8h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8z"
+           />
+         </svg>
+       </span>
        <div
-         className="ant-alert-message"
-       />
-       <div
-         className="ant-alert-description"
+         className="ant-alert-content"
        >
-         If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         <div
+           className="ant-alert-message"
+         />
+         <div
+           className="ant-alert-description"
+         >
+           If you would like to request an icon for an eToken that has already been created, please email icons@e.cash.
+         </div>
        </div>
      </div>
    </div>,
    <div
      className="ant-collapse ant-collapse-icon-position-left sc-gqjmRU eryBsW"
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:114:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Without wallet defined

bytesofman added inline comments.
web/cashtab/src/components/Send/SendToken.js
5

This is called TokenInstructionAlert in /Common/Alert.js but is imported here as TokenIconAlert ... gonna have a bad time ;)

TokenIconAlert is the more descriptive of the two, please use this througout.

This revision now requires changes to proceed.Nov 26 2021, 22:38

responding to review feedback

This revision is now accepted and ready to land.Nov 26 2021, 23:02