[Cashtab] Refactor token icon link
ClosedPublic
Actions

Authored by kieran709 on Nov 29 2021, 16:29.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCe84751712ed9: [Cashtab] Refactor token icon link

Summary

Removed /32/ from tokenIconUrl baselink and inserted /32/ in areas of the code referencing tokenIconUrl. Related to task T2014

Test Plan

cd web/cashtab && npm start
ensure token icons are displaying correctly in the Tx component
navigate to eTokens Page
ensure each token list item's icon is displaying correctly in the TokenList component

Diff Detail

Repository

rABC Bitcoin ABC

Branch

token-icon-link-refactor

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17448
Build 34724: Build Diff	cashtab-tests
Build 34723: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 29 2021, 16:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2021, 16:29

kieran709 requested review of this revision.Nov 29 2021, 16:29

Harbormaster completed remote builds in B17444: Diff 31147.Nov 29 2021, 16:32

kieran709 retitled this revision from [Cashtab] Refactor token i con link to [Cashtab] Refactor token icon link.Nov 29 2021, 18:29

kieran709 edited the summary of this revision. (Show Details)

Looks like implementation is missed on SendToken.js screen, causing broken image icons there.

Please confirm you have all bases covered by checking for all files where the string tokenIconsUrl appears:

grep -r 'tokenIconsUrl' src/ [checks all files in the src/ folder for the string 'tokenIconsUrl'...so in this case, I ran the command from /web/cashtab, so it's checking /web/cashtab/src

This revision now requires changes to proceed.Nov 29 2021, 19:58

responding to review feedback

Harbormaster completed remote builds in B17448: Diff 31152.Nov 29 2021, 20:38

bytesofman accepted this revision.Nov 29 2021, 21:30

This revision is now accepted and ready to land.Nov 29 2021, 21:30

Closed by commit rABCe84751712ed9: [Cashtab] Refactor token icon link (authored by kieran709). · Explain WhyNov 29 2021, 21:47

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCe84751712ed9: [Cashtab] Refactor token icon link.