Page MenuHomePhabricator
Differential D10604

gui: Call setWalletActionsEnabled(true) only for the first wallet
ClosedPublic
Actions

Authored by PiRK on Dec 1 2021, 15:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC96b27196ccd0: gui: Call setWalletActionsEnabled(true) only for the first wallet
Summary

On master there is a bug:

  • open an encrypted wallet; please note that the "Encrypt Wallet..." menu item is disabled that is expected
  • then open any other wallet; note that the "Encrypt Wallet..." menu item gets enabled that is wrong

This PR fixes this bug.

This is a backport of core-gui#43

Test Plan

ninja all check-all

Failed to reproduce the bug after this change.

Diff Detail

Event Timeline

PiRK created this revision.Dec 1 2021, 15:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2021, 15:06
PiRK requested review of this revision.Dec 1 2021, 15:06
teamcity edited the summary of this revision. (Show Details)Dec 1 2021, 15:07
Harbormaster completed remote builds in B17493: Diff 31211.Dec 1 2021, 15:33
Fabien requested changes to this revision.Dec 1 2021, 16:07
Fabien added a subscriber: Fabien.

You linked the issue, not the PR

This revision now requires changes to proceed.Dec 1 2021, 16:07
PiRK requested review of this revision.Dec 1 2021, 16:18
PiRK edited the summary of this revision. (Show Details)

Sorry about that. Fixed.

Fabien accepted this revision.Dec 3 2021, 21:18
This revision is now accepted and ready to land.Dec 3 2021, 21:18
Closed by commit rABC96b27196ccd0: gui: Call setWalletActionsEnabled(true) only for the first wallet (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 4 2021, 18:56
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC96b27196ccd0: gui: Call setWalletActionsEnabled(true) only for the first wallet.

Revision Contents
Changeset List

PathSize
src/
qt/
9 lines

Diff 31211

View Options

src/qt/bitcoingui.cpp

Loading...