Page MenuHomePhabricator
Differential D10619

[Cashtab] add eToken icon to send page
AbandonedPublic
Actions

Authored by kieran709 on Dec 2 2021, 18:12.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Using the same logic as TokenListItem, eToken icon added to send page. Related to task T1988.

Custom Token:

resize-token-icons-send-page.png (1×1 px, 356 KB)

Generated Token:

resize-token-icons-send-page-2.png (1×1 px, 250 KB)

Test Plan

cd web/cashtab
npm start
navigate to eTokens tab
select a token with a custom icon
ensure icon displays at top of token table
navigate back to eTokens tab
select a token with a generated icon
ensure icon displays at top of token table

Diff Detail

Repository
rABC Bitcoin ABC
Branch
display-icon-etoken-page
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17515
Build 34856: Build Diffcashtab-tests
Build 34855: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 2 2021, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2021, 18:12
kieran709 requested review of this revision.Dec 2 2021, 18:12
Harbormaster completed remote builds in B17515: Diff 31236.Dec 2 2021, 18:16
bytesofman requested changes to this revision.Dec 2 2021, 23:05
bytesofman added inline comments.
web/cashtab/src/components/Send/SendToken.js
365

Just "Icon" for the label

368

Other available sizes here are 64, 128, 256, and 512

Try all of them and use the biggest one that works

This revision now requires changes to proceed.Dec 2 2021, 23:05
kieran709 updated this revision to Diff 31258.Dec 3 2021, 19:14

increased size to 256, the biggest size that will fit.

Harbormaster completed remote builds in B17530: Diff 31258.Dec 3 2021, 19:18
kieran709 edited the summary of this revision. (Show Details)Dec 3 2021, 19:53
bytesofman requested changes to this revision.Dec 3 2021, 22:33
bytesofman added inline comments.
web/cashtab/src/components/Send/SendToken.js
374 ↗(On Diff #31258)

If the token does not have a custom icon, keep it 32x32

height="32"

375 ↗(On Diff #31258)

width="32"

This revision now requires changes to proceed.Dec 3 2021, 22:33
kieran709 updated this revision to Diff 31284.Dec 6 2021, 15:49

responding to review feedback, generated icons are now 32px.

Harbormaster completed remote builds in B17544: Diff 31284.Dec 6 2021, 15:52
bytesofman accepted this revision.Dec 8 2021, 15:49
This revision is now accepted and ready to land.Dec 8 2021, 15:49
kieran709 abandoned this revision.Dec 8 2021, 16:53

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
34 lines

Diff 31236

View Options

web/cashtab/src/components/Send/SendToken.js

Loading...