Removed unused 'prefix' var from cashaddr obj in useBCH, related to task T2063.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab/src/hooks
inspect useBCH.js
ensure 'prefix' is removed from obj on line 134.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- remove-unused-var-useBCH
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17550 Build 34926: Build Diff cashtab-tests Build 34925: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()
Snapshot name: `Wallet without BCH balance 1`
- Snapshot - 1
+ Received + 1
@@ -110,11 +110,11 @@
5.5
XEC
(
- $
+ $
NaN
USD
) to create a token
</p>,
at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:54:18)
at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
at new Promise (<anonymous>)
at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests: Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()
Snapshot name: `Wallet with BCH balances 1`
- Snapshot - 1
+ Received + 1
@@ -110,11 +110,11 @@
5.5
XEC
(
- $
+ $
NaN
USD
) to create a token
</p>,
at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:68:18)
at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
at new Promise (<anonymous>)
at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests: Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()
Snapshot name: `Wallet with BCH balances and tokens 1`
- Snapshot - 1
+ Received + 1
@@ -110,11 +110,11 @@
5.5
XEC
(
- $
+ $
NaN
USD
) to create a token
</p>,
at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:82:18)
at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
at new Promise (<anonymous>)
at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests: Without wallet defined ======
Error: expect(received).toMatchSnapshot()
Snapshot name: `Without wallet defined 1`
- Snapshot - 1
+ Received + 1
@@ -110,11 +110,11 @@
5.5
XEC
(
- $
+ $
NaN
USD
) to create a token
</p>,
at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:114:18)
at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
at new Promise (<anonymous>)
at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
at processTicksAndRejections (node:internal/process/task_queues:94:5)Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Without wallet defined