Differential D10651

[avalanche] Add a facility to replace a proof in the pool
ClosedPublic
Actions

Authored by Fabien on Dec 8 2021, 19:26.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC555264a101d6: [avalanche] Add a facility to replace a proof in the pool

Summary

This is selected according to the ConflictingProofComparator(). The previous addProof() function keep the previous behavior and is renamed to make the intent clearer. This will be used to proceed to proof replacement in future diffs. There is no change in behavior.

Ref T1854.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_add_proof_if_preferred

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17585
Build 34996: Build Diff	build-without-wallet · build-debug · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang
Build 34995: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 8 2021, 19:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2021, 19:26

Fabien requested review of this revision.Dec 8 2021, 19:26

Harbormaster completed remote builds in B17585: Diff 31331.Dec 8 2021, 19:42

Fabien added a child revision: D10524: [avalanche] Select the favorite orphan in case of a conflict.Dec 9 2021, 16:56

Fabien added a child revision: D10660: [avalanche] Select the favorite conflicting proof.Dec 9 2021, 17:01

Fabien added a child revision: D10525: [avalanche] Make it possible to replace a proof.Dec 10 2021, 10:58

deadalnix accepted this revision.Dec 10 2021, 16:30

This revision is now accepted and ready to land.Dec 10 2021, 16:30

Closed by commit rABC555264a101d6: [avalanche] Add a facility to replace a proof in the pool (authored by Fabien). · Explain WhyDec 11 2021, 11:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC555264a101d6: [avalanche] Add a facility to replace a proof in the pool.

Fabien removed a child revision: D10525: [avalanche] Make it possible to replace a proof.Dec 14 2021, 15:55

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

8 lines

26 lines

37 lines

test/

proofpool_tests.cpp

176 lines

Diff 31331

src/avalanche/peermanager.cpp

Loading...

src/avalanche/proofpool.h

Loading...

src/avalanche/proofpool.cpp

Loading...

src/avalanche/test/proofpool_tests.cpp

Loading...