Paths

Table of Contentst

Differential D10657

Move import and watchonly tests to be legacy wallet only in wallet_balance.py
ClosedPublic
Actions

Authored by PiRK on Dec 9 2021, 15:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4a6f5dba7041: Move import and watchonly tests to be legacy wallet only in wallet_balance.py

Summary

Imports and watchonly behavior are legacy wallet only, so make them only run when the test is in legacy wallet mode.

This is a backport of core#18788 [5/16]
https://github.com/bitcoin/bitcoin/pull/18788/commits/a42652ec10c733a5bf37e418e45d4841f54331b4

Test Plan

test/functional/test_runner.py wallet_balance

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18788

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17593
Build 35012: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35011: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 9 2021, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 9 2021, 15:18

PiRK requested review of this revision.Dec 9 2021, 15:18

teamcity edited the summary of this revision. (Show Details)Dec 9 2021, 15:18

Harbormaster completed remote builds in B17593: Diff 31339.Dec 9 2021, 15:52

Fabien accepted this revision.Dec 10 2021, 09:10

This revision is now accepted and ready to land.Dec 10 2021, 09:10

Closed by commit rABC4a6f5dba7041: Move import and watchonly tests to be legacy wallet only in wallet_balance.py (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyDec 13 2021, 07:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4a6f5dba7041: Move import and watchonly tests to be legacy wallet only in wallet_balance.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

1 line

wallet_balance.py

60 lines

Diff 31339

View Options

test/functional/test_runner.py