Differential D10661

[avalanche] Select the favorite orphan in case of a conflict during a rescan
ClosedPublic
Actions

Authored by Fabien on Dec 10 2021, 09:44.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCe0ae7b67d9e6: [avalanche] Select the favorite orphan in case of a conflict during a rescan

Summary

This is a follow-up to D10524, apply the same rule for the proofs newly orphaned after a new block is mined.

Ref T1854.

Depends on D10524.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_replace_orphan_rescan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17602
Build 35030: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35029: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 10 2021, 09:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2021, 09:44

Fabien requested review of this revision.Dec 10 2021, 09:44

Harbormaster completed remote builds in B17602: Diff 31348.Dec 10 2021, 10:01

Rebase

Harbormaster completed remote builds in B17619: Diff 31376.Dec 13 2021, 10:15

deadalnix accepted this revision.Dec 14 2021, 17:47

This revision is now accepted and ready to land.Dec 14 2021, 17:47

Closed by commit rABCe0ae7b67d9e6: [avalanche] Select the favorite orphan in case of a conflict during a rescan (authored by Fabien). · Explain WhyDec 14 2021, 19:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe0ae7b67d9e6: [avalanche] Select the favorite orphan in case of a conflict during a rescan.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

2 lines

test/

peermanager_tests.cpp

54 lines

Diff 31348

View Options

src/avalanche/peermanager.cpp