Paths

Table of Contentst

Differential D10664

Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py
ClosedPublic
Actions

Authored by PiRK on Dec 10 2021, 17:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa2c5e69ed4d3: Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py

Summary

addmultisigaddress is not available in descriptor wallets, so only run these when testing legacy wallets

This is a backport of core#18788 [8/15]
https://github.com/bitcoin/bitcoin/pull/18788/commits/59d3da5bce4ebd9c2291d8f201a53ee087938b21

Test Plan

test/functional/test_runner.py wallet_address_types

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18788

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17613
Build 35052: Build Diff	build-diff · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 35051: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 10 2021, 17:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2021, 17:30

PiRK requested review of this revision.Dec 10 2021, 17:30

teamcity edited the summary of this revision. (Show Details)Dec 10 2021, 17:31

Harbormaster completed remote builds in B17613: Diff 31362.Dec 10 2021, 17:45

Fabien accepted this revision.Dec 13 2021, 09:44

This revision is now accepted and ready to land.Dec 13 2021, 09:44

Closed by commit rABCa2c5e69ed4d3: Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyDec 16 2021, 15:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa2c5e69ed4d3: Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

1 line

wallet_address_types.py

54 lines

Diff 31362

View Options

test/functional/test_runner.py