Differential D10731

qt: Make transaction notification queue wallet specific
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 08:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCab3b03e478e8: qt: Make transaction notification queue wallet specific

Summary

Drop global vQueueNotifications and make one for each wallet.

https://github.com/bitcoin-core/gui/pull/120/commits/989e579d07bb5031639060b717f7a0be15d10e29

refactor: qt: Use vQueueNotifications.clear()

https://github.com/bitcoin-core/gui/pull/120/commits/241434200ec2067673d8522fee4f1228abfd8247

This is a backport of core-gui#120 [2/2]

Depends on D10730

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gui_pr120

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17741
Build 35308: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35307: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 08:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 08:11

PiRK requested review of this revision.Dec 23 2021, 08:11

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 08:13

PiRK edited the summary of this revision. (Show Details)Dec 23 2021, 08:13

PiRK added a parent revision: D10730: move-only: Define TransactionNotification before TransactionTablePriv.

Harbormaster completed remote builds in B17741: Diff 31556.Dec 23 2021, 08:34

Fabien accepted this revision.Dec 23 2021, 09:10

This revision is now accepted and ready to land.Dec 23 2021, 09:10

Closed by commit rABCab3b03e478e8: qt: Make transaction notification queue wallet specific (authored by Joo Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyDec 23 2021, 13:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCab3b03e478e8: qt: Make transaction notification queue wallet specific.

Revision Contents
Changeset List

Path

Size

src/

qt/

transactiontablemodel.cpp

39 lines

Diff 31556

View Options

src/qt/transactiontablemodel.cpp

qt: Make transaction notification queue wallet specificClosedPublicActions