Paths

Table of Contentst

Differential D10735

[secp256k1]refactor: Use (int)&(int) in boolean context to avoid compiler warning
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 10:26.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe7571cd4ee84: [secp256k1]refactor: Use (int)&(int) in boolean context to avoid compiler…

Summary

This fixes a compiler warning:

./src/ecdsa_impl.h:312:12: warning: use of bitwise '&' with boolean operands [-Wbitwise-instead-of-logical]
    return !secp256k1_scalar_is_zero(sigr) & !secp256k1_scalar_is_zero(sigs);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a backport of secp256k1#1009

Test Plan

With clang14:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17745
Build 35316: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-clang · build-diff · build-clang-tidy · build-debug
Build 35315: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 10:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 10:27

PiRK requested review of this revision.Dec 23 2021, 10:27

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 10:27

PiRK edited the test plan for this revision. (Show Details)Dec 23 2021, 10:29

PiRK mentioned this in D10726: cast bool operands to int to silence compiler warning.Dec 23 2021, 10:29

Harbormaster completed remote builds in B17745: Diff 31560.Dec 23 2021, 10:38

Fabien accepted this revision.Dec 23 2021, 10:49

This revision is now accepted and ready to land.Dec 23 2021, 10:49

Closed by commit rABCe7571cd4ee84: [secp256k1]refactor: Use (int)&(int) in boolean context to avoid compiler… (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 23 2021, 13:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe7571cd4ee84: [secp256k1]refactor: Use (int)&(int) in boolean context to avoid compiler….

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

4 lines

Diff 31560

src/secp256k1/src/ecdsa_impl.h

Loading...