Differential D10726

cast bool operands to int to silence compiler warning
ClosedPublic
Actions

Authored by PiRK on Dec 22 2021, 16:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfcf196f63c2a: cast bool operands to int to silence compiler warning

Summary

I noticed the compiler warning while running the test plan for D10725.

../src/interfaces/chain.cpp:291:20: warning: use of bitwise '&' with boolean operands [-Wbitwise-instead-of-logical]
            return FillBlock(ancestor, ancestor_out, lock) &
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a backport of core#23573

Test Plan

cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all

I'm using clang 14.0.0

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 22 2021, 16:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2021, 16:37

PiRK requested review of this revision.Dec 22 2021, 16:37

teamcity edited the summary of this revision. (Show Details)Dec 22 2021, 16:38

Harbormaster completed remote builds in B17733: Diff 31545.Dec 22 2021, 16:52

split the diff (secp256k1 changes are now in D10735)

Harbormaster completed remote builds in B17746: Diff 31561.Dec 23 2021, 10:48

Fabien accepted this revision.Dec 23 2021, 10:53

This revision is now accepted and ready to land.Dec 23 2021, 10:53

Closed by commit rABCfcf196f63c2a: cast bool operands to int to silence compiler warning (authored by PiRK). · Explain WhyDec 23 2021, 13:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfcf196f63c2a: cast bool operands to int to silence compiler warning.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.cpp

9 lines

Diff 31564

View Options

cast bool operands to int to silence compiler warningClosedPublicActions