refactor: remove use of boost::algorithm::replace_first
ClosedPublic
Actions

Authored by PiRK on Jan 6 2022, 08:54.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe0303815ca4a: refactor: remove use of boost::algorithm::replace_first

Summary

This is a backport of core#20067

I remove a trivial comment, to avoid having two comments on the previous lines.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20067

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17800
Build 35426: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-clang · build-debug
Build 35425: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 6 2022, 08:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2022, 08:55

PiRK requested review of this revision.Jan 6 2022, 08:55

teamcity edited the summary of this revision. (Show Details)Jan 6 2022, 08:55

Harbormaster completed remote builds in B17800: Diff 31657.Jan 6 2022, 09:10

Fabien accepted this revision.Jan 6 2022, 13:17

This revision is now accepted and ready to land.Jan 6 2022, 13:17

Closed by commit rABCe0303815ca4a: refactor: remove use of boost::algorithm::replace_first (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyJan 6 2022, 13:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe0303815ca4a: refactor: remove use of boost::algorithm::replace_first.

PiRK added a reverting change: D10793: Revert "refactor: remove use of boost::algorithm::replace_first".Jan 10 2022, 09:18

PiRK added a reverting change: rABC7be47fd527cf: Revert "refactor: remove use of boost::algorithm::replace_first".Jan 10 2022, 13:22

Revision Contents
Changeset List

Path

Size

src/

core_read.cpp

6 lines

Diff 31657

View Options

refactor: remove use of boost::algorithm::replace_firstClosedPublicActions