Page MenuHomePhabricator

added timezone constant for all npm tests
ClosedPublic

Authored by darn-it-dan on Jan 11 2022, 03:40.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCa0d16b267c32: added timezone constant for all npm tests
Summary

Allowing npm tests to run in UTC timezone.
This is needed because we have a jest test that checks a DateTime formatter function.
However it formats the date time to the local machines timezone, which causes the test to fail.
This change fixes that failing test no matter which time zone the tests are run.

Test Plan

Change your machines to different time zones and run the npm tests.

bash
cd bitcoin-abc/web/cashtab
npm i
npm test
# all tests should pass!

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-npm-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17868
Build 35562: Build Diffcashtab-tests
Build 35561: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 11 2022, 03:40
This revision is now accepted and ready to land.Jan 11 2022, 22:37

Will green this, pending contact on telegram to coordinate landing

This revision now requires changes to proceed.Jan 11 2022, 22:38

Will green this, pending contact on telegram to coordinate landing

pinged you :)

This revision is now accepted and ready to land.Jan 20 2022, 02:09