qt: Hide peer detail view if multiple are selected
ClosedPublic
Actions

Authored by PiRK on Jan 11 2022, 13:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC45627eef6575: qt: Hide peer detail view if multiple are selected

Summary

Currently if multiple peers are selected the peer detail view shows the first new selected peer.

With this PR the peer detail view is hidden when multiple peers are selected. It is also a slight refactor to simplify and remove duplicate code.

This is a backport of core-gui#13

Test Plan

ninja all check-all

Run bitcoin-qt, open menu Window > Peer. Select multiple peers.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 11 2022, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2022, 13:21

PiRK requested review of this revision.Jan 11 2022, 13:21

teamcity edited the summary of this revision. (Show Details)Jan 11 2022, 13:21

Harbormaster completed remote builds in B17883: Diff 31766.Jan 11 2022, 13:36

Fabien accepted this revision.Jan 11 2022, 16:10

This revision is now accepted and ready to land.Jan 11 2022, 16:10

Closed by commit rABC45627eef6575: qt: Hide peer detail view if multiple are selected (authored by Joo Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyJan 11 2022, 16:40

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC45627eef6575: qt: Hide peer detail view if multiple are selected.

Revision Contents
Changeset List

Path

Size

src/

qt/

rpcconsole.h

7 lines

rpcconsole.cpp

51 lines

Diff 31774

View Options

src/qt/rpcconsole.h