In order to make further progress with the dark theme, the antd Descriptions in SendToken.js need custom CSS. Currently, it is not possible to change the background and foreground colors in left most column on the table that contains the token's stats. If left unchanged the column would maintain its white background and dark text when the app is toggled to the dark theme. In order to exercise more control over the table a whole, I have included both columns (.ant-descriptions-item-lable & .ant-descriptions-item-content) in AntDescriptionsCss. Related to task T2173.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC1c524ade67d3: [Cashtab] Add custom styling to Antd Descriptions
cd web/cashtab
npm start
navigate to send token page
ensure that content in the table is legible
In your IDE:
In theme.js, change the value of props.theme.tokenListItem.background and props.theme.tokenListItem.color
In browser:
navigate to the Send Token page.
Ensure that the colors selected in the previous step match what is rendering on the screen.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- custom-css-antd-descriptions
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17934 Build 35690: Build Diff cashtab-tests Build 35689: arc lint + arc unit
Event Timeline
Comment Actions
Please expand on the description of what is going on here. It looks like you are trying to put more css controls into the the theme.js object -- which is good -- but it is not clear why this is necessary. Is the issue that the current values being used are antd defaults, but we need to be able to change them? If so, please clarify. The test plan should also include changing colors in theme.js and confirming that they change on this screen.