[Cashtab] Replace hardcoded colors with references to theme.js
ClosedPublic
Actions

Authored by kieran709 on Jan 13 2022, 16:40.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCc203507cf06f: [Cashtab] Replace hardcoded colors with references to theme.js

Summary

Replace all hardcoded colors with references to theme.js. Related to task T2137.

Test Plan

cd web/cashtab && npm start
use 'color' as a search term in ide
ensure each component that used hardcoded colors has been updated to use references to theme.js
ensure that colors are displaying properly within these components.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

replace-hardcoded-css-colors

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17950
Build 35722: Build Diff	cashtab-tests
Build 35721: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jan 13 2022, 16:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2022, 16:40

kieran709 requested review of this revision.Jan 13 2022, 16:40

Harbormaster completed remote builds in B17903: Diff 31796.Jan 13 2022, 16:43

bytesofman requested changes to this revision.Jan 13 2022, 17:37

bytesofman added inline comments.

web/cashtab/src/components/Configure/Configure.js
80 ↗	(On Diff #31796)	Maybe this is preferable, but it is not related to the current diff. Please back this out and create a separate task to handle this.

This revision now requires changes to proceed.Jan 13 2022, 17:37

responding to review feedback

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook sends XEC correctly with an encrypted OP_RETURN message ======
Error: Failed: Object {
  "error": "429 Too Many Requests",
  "success": false,
}
    at Env.it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
    at it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:148:5)
    at addSpecsToSuite (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:36:1)
    at Runtime._execModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:746:10)
====== CashTab Unit Tests: useBCH hook handleEncryptedOpReturn() correctly encrypts a message based on a valid cash address ======
Error: Failed: Object {
  "error": "429 Too Many Requests",
  "success": false,
}
    at Env.it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
    at it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:588:5)
    at addSpecsToSuite (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:36:1)
    at Runtime._execModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:746:10)
====== CashTab Unit Tests: useBCH hook getRecipientPublicKey() correctly retrieves the public key of a cash address ======
Error: Failed: Object {
  "error": "429 Too Many Requests",
  "success": false,
}
    at Env.it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
    at it (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:681:5)
    at addSpecsToSuite (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:36:1)
    at Runtime._execModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/work/web/cashtab/node_modules/jest-runtime/build/index.js:746:10)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook sends XEC correctly with an encrypted OP_RETURN message
CashTab Unit Tests: useBCH hook handleEncryptedOpReturn() correctly encrypts a message based on a valid cash address
CashTab Unit Tests: useBCH hook getRecipientPublicKey() correctly retrieves the public key of a cash address

Harbormaster completed remote builds in B17915: Diff 31814.Jan 14 2022, 14:45

bytesofman requested changes to this revision.Jan 19 2022, 20:46

bytesofman added inline comments.

web/cashtab/src/components/Configure/Configure.js
93 ↗	(On Diff #31814)	This is changing from `#eee;` to `#fff;` -- is this the intention? If so, not related to this diff -- this diff should only replace hard coded colors with variables. Please create a new task and a new diff if some colors need to be adjusted.
127 ↗	(On Diff #31814)	This is changing from `#eee;` to `#fff;` -- is this the intention? If so, not related to this diff -- this diff should only replace hard coded colors with variables. Please create a new task and a new diff if some colors need to be adjusted.