Differential D10866

[net processing] Move nStartingHeight to Peer
ClosedPublic
Actions

Authored by Fabien on Jan 24 2022, 10:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCeab69427ac7b: [net processing] Move nStartingHeight to Peer

Summary

Partial backport of core#19829:
https://github.com/bitcoin/bitcoin/pull/19829/commits/77a2c2f8f91a5c5a140fd970f9a3a142b43902bf

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19829_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17973
Build 35768: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35767: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2022, 10:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2022, 10:52

Fabien requested review of this revision.Jan 24 2022, 10:52

teamcity edited the summary of this revision. (Show Details)Jan 24 2022, 10:53

Fabien added a child revision: D10867: [net processing] Rename nStartingHeight to m_starting_height.Jan 24 2022, 11:03

Harbormaster completed remote builds in B17973: Diff 31907.Jan 24 2022, 11:27

PiRK accepted this revision.Jan 24 2022, 13:00

This revision is now accepted and ready to land.Jan 24 2022, 13:00

Closed by commit rABCeab69427ac7b: [net processing] Move nStartingHeight to Peer (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 24 2022, 16:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeab69427ac7b: [net processing] Move nStartingHeight to Peer.

Revision Contents
Changeset List

Path

Size

src/

1 line

1 line

5 lines

26 lines

qt/

rpcconsole.cpp

4 lines

rpc/

net.cpp

2 lines

Diff 31907

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/qt/rpcconsole.cpp

View Options

[net processing] Move nStartingHeight to PeerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31907

src/net.h

src/net.cpp

src/net_processing.h

src/net_processing.cpp

src/qt/rpcconsole.cpp

src/rpc/net.cpp

[net processing] Move nStartingHeight to Peer
ClosedPublic
Actions

Revision Contents
Changeset List