Differential D10898

Fix a reversed bool flag in the getpeerinfo RPC
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 17:44.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb791a96225bd: Fix a reversed bool flag in the getpeerinfo RPC

Summary

This is a rebase bug introduced in D10862. The functional test has been extended to cover the fields that were missing due to this error.

Test Plan

./test/functional/test_runner.py rpc_net

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_fstatestats

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18014
Build 35850: Build Diff	build-clang · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff · build-debug
Build 35849: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 25 2022, 17:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 17:44

Fabien requested review of this revision.Jan 25 2022, 17:44

Fabien added a child revision: D10899: [net processing] Move ping data fields to net processing.Jan 25 2022, 17:49

PiRK accepted this revision.Jan 25 2022, 17:51

This revision is now accepted and ready to land.Jan 25 2022, 17:51

Harbormaster completed remote builds in B18014: Diff 31970.Jan 25 2022, 18:02

Closed by commit rABCb791a96225bd: Fix a reversed bool flag in the getpeerinfo RPC (authored by Fabien). · Explain WhyJan 25 2022, 18:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb791a96225bd: Fix a reversed bool flag in the getpeerinfo RPC.

Revision Contents
Changeset List

Path

Size

src/

rpc/

net.cpp

2 lines

test/

functional/

rpc_net.py

5 lines

Diff 31970

View Options

src/rpc/net.cpp