Page MenuHomePhabricator

[avalanche] Fix a potential use after free issue
ClosedPublic

Authored by Fabien on Feb 9 2022, 09:37.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCc6cca1212e4a: [avalanche] Fix a potential use after free issue
Summary

There is a typo introduced in D10711. We need to access the proof associated with a peer after it gets deleted, so we copy the shared pointer. Unfortunately there is a place where the original pointer was used instead, causing a potential use after free issue.

Ref T1854.

Test Plan
./contrib/teamcity/build-configurations.py build-asan

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_use_after_free
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18218
Build 36244: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 36243: arc lint + arc unit