Page MenuHomePhabricator
Differential D11097

[Cashtab] Create TokenIcon Component
ClosedPublic
Actions

Authored by kieran709 on Feb 22 2022, 18:00.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC4566bcd1dac4: [Cashtab] Create TokenIcon Component
Summary

Created TokenIcon component and added it throughout the app.

Test Plan

cd web/cashtab
npm start
Ensure that there are token txs within recent history
Check that custom token icons and generated icons are appearing
Naviagate to eTokens tab
Check that custom token icons and generated icons are appearing
Navigate to SentToken page
Check that custom icons and generated icons are appearing in the amount field of the send form

Diff Detail

Repository
rABC Bitcoin ABC
Branch
create-token-icon-component
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18343
Build 36491: Build Diffcashtab-tests
Build 36490: arc lint + arc unit

Event Timeline

kieran709 created this revision.Feb 22 2022, 18:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2022, 18:00
kieran709 requested review of this revision.Feb 22 2022, 18:00
Harbormaster completed remote builds in B18339: Diff 32493.Feb 22 2022, 18:04
bytesofman requested changes to this revision.Feb 22 2022, 20:07
  1. Remove the popover functionality
  2. Make the default size 64 on the SendToken.js page
This revision now requires changes to proceed.Feb 22 2022, 20:07
kieran709 updated this revision to Diff 32495.Feb 22 2022, 20:20

Removed antd popover from SendToken.js per discussion with bytesofman.

Harbormaster completed remote builds in B18341: Diff 32495.Feb 22 2022, 20:23
kieran709 updated this revision to Diff 32496.Feb 22 2022, 20:30

Increased token icon size on SendToken page to 64.

Harbormaster completed remote builds in B18342: Diff 32496.Feb 22 2022, 20:33
bytesofman requested changes to this revision.Feb 22 2022, 21:07
bytesofman added inline comments.
web/cashtab/src/components/Home/TokenListItem.js
6 ↗(On Diff #32496)

Can you remove TokenIconWrapper without impacting this page?

This revision now requires changes to proceed.Feb 22 2022, 21:07
kieran709 updated this revision to Diff 32497.Feb 22 2022, 22:59

Removed styled component TokenIconWrapper.

kieran709 updated this revision to Diff 32498.Feb 22 2022, 23:01

Upated snapshots.

Harbormaster completed remote builds in B18343: Diff 32497.Feb 22 2022, 23:02
Harbormaster completed remote builds in B18344: Diff 32498.
kieran709 updated this revision to Diff 32499.Feb 23 2022, 00:26

Re-added TokenIconWrapper & updated snapshots.

Harbormaster completed remote builds in B18345: Diff 32499.Feb 23 2022, 00:29
bytesofman accepted this revision.Feb 23 2022, 21:36
bytesofman added inline comments.
web/cashtab/src/components/Tokens/TokenIcon.js
18 ↗(On Diff #32499)

Noting here that it's okay to leave these hardcoded. Intent here is for the blockies to never be more than 32. We might want to change that later but probably not.

This revision is now accepted and ready to land.Feb 23 2022, 21:36
Closed by commit rABC4566bcd1dac4: [Cashtab] Create TokenIcon Component (authored by kieran709). · Explain WhyFeb 25 2022, 16:35
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC4566bcd1dac4: [Cashtab] Create TokenIcon Component.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Home/
43 lines
36 lines
__tests__/
__snapshots__/
Send/
52 lines
Tokens/
36 lines

Diff 32497

View Options

web/cashtab/src/components/Home/TokenListItem.js

Loading...
View Options

web/cashtab/src/components/Home/Tx.js

Loading...
View Options

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/components/Tokens/TokenIcon.js

Loading...