Differential D11142

[avalanche] Add the score and staked amount to the decodeavalancheproof RPC
ClosedPublic
Actions

Authored by Fabien on Mar 7 2022, 16:23.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3c256b080b40: [avalanche] Add the score and staked amount to the decodeavalancheproof RPC

Summary

The missing score is certainly an oversight and the staked amount a convenience to avoid summing all the stake amounts.

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_decodeavalancheproof_score

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18427
Build 36651: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff · build-clang · build-debug
Build 36650: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 7 2022, 16:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2022, 16:23

Fabien requested review of this revision.Mar 7 2022, 16:23

Harbormaster completed remote builds in B18425: Diff 32624.Mar 7 2022, 16:41

Typos

Harbormaster completed remote builds in B18427: Diff 32627.Mar 7 2022, 17:57

PiRK accepted this revision.Mar 8 2022, 13:15

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/rpc/avalanche.cpp
383 ↗	(On Diff #32624)	why

This revision is now accepted and ready to land.Mar 8 2022, 13:15

ignore the inline comment. I failed to completely delete it before accepting the revision.

Closed by commit rABC3c256b080b40: [avalanche] Add the score and staked amount to the decodeavalancheproof RPC (authored by Fabien). · Explain WhyMar 11 2022, 08:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3c256b080b40: [avalanche] Add the score and staked amount to the decodeavalancheproof RPC.

Revision Contents
Changeset List

Path

Size

src/

rpc/

avalanche.cpp

7 lines

test/

functional/

abc_rpc_avalancheproof.py

9 lines

Diff 32627

View Options

src/rpc/avalanche.cpp