Page MenuHomePhabricator

[Cashtab] Removed unused import from TokenIcon.js
AbandonedPublic

Authored by kieran709 on Mar 8 2022, 15:19.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Removed unused styled-components import from TokenIcon.js Related to task T2297.

Test Plan

Navigate to /web/cashtab/components/Tokens/TokenIcon.js and ensure styled-components import is removed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-unused-import-token-icon
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18436
Build 36669: Build Diffcashtab-tests
Build 36668: arc lint + arc unit

Event Timeline

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #43672, branch 'refs/tags/phabricator/diff/32636'
Triggered 2022-03-08 15:19:54 by 'Phabricator Staging (phabricator-staging)'
Started 2022-03-08 15:19:56 on agent 'buildagent1'
Finished 2022-03-08 15:20:02 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 5): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/viewLog.html?buildId=364202&buildTypeId=BitcoinABC_BitcoinAbcStaging 
TeamCity server version is 2019.2.4 (build 72059), server timezone: GMT (UTC)

[15:19:54]E: bt15 (running for 7s)
[15:19:54]i: TeamCity server version is 2019.2.4 (build 72059)
[15:19:54] : Collecting changes in 2 VCS roots
[15:19:54] :	 [Collecting changes in 2 VCS roots] VCS Root details
[15:19:54] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=5, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[15:19:54] :		 [VCS Root details] "abc-infrastructure" {instance id=7, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[15:19:56] : The build is removed from the queue to be prepared for the start
[15:20:02]W: This build has not been started because some of the builds it depends on failed to start
[15:20:02]E: Snapshot dependency "Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout" failed
[15:20:02] : Build finished
bytesofman requested changes to this revision.Mar 8 2022, 17:29

Make sure to run npm test to see if snapshots need to update

This revision now requires changes to proceed.Mar 8 2022, 17:29

Added comment to force rerun of tests.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #43681, branch 'refs/tags/phabricator/diff/32640'
Triggered 2022-03-09 15:41:37 by 'Phabricator Staging (phabricator-staging)'
Started 2022-03-09 15:41:39 on agent 'buildagent1'
Finished 2022-03-09 15:41:44 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'PhabBitcoinAbcStagingRo' (Git, instance id 18): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/viewLog.html?buildId=364265&buildTypeId=BitcoinABC_BitcoinAbcStaging 
TeamCity server version is 2019.2.4 (build 72059), server timezone: GMT (UTC)

[15:41:37]E: bt15 (running for 7s)
[15:41:37]i: TeamCity server version is 2019.2.4 (build 72059)
[15:41:37] : Collecting changes in 2 VCS roots
[15:41:37] :	 [Collecting changes in 2 VCS roots] VCS Root details
[15:41:37] :		 [VCS Root details] "phab-bitcoin-abc-staging-ro" {instance id=18, parent internal id=14, parent id=PhabBitcoinAbcStagingRo, description: "https://reviews.bitcoinabc.org/source/bitcoin-abc-staging.git#refs/heads/master"}
[15:41:37] :		 [VCS Root details] "abc-infrastructure" {instance id=7, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[15:41:39] : The build is removed from the queue to be prepared for the start
[15:41:44]W: This build has not been started because some of the builds it depends on failed to start
[15:41:44]E: Snapshot dependency "Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout" failed
[15:41:44] : Build finished

removed unnecessary comment

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #43682, branch 'refs/tags/phabricator/diff/32641'
Triggered 2022-03-09 15:43:45 by 'Phabricator Staging (phabricator-staging)'
Started 2022-03-09 15:43:47 on agent 'buildagent1'
Finished 2022-03-09 15:43:52 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'PhabBitcoinAbcStagingRo' (Git, instance id 18): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/viewLog.html?buildId=364267&buildTypeId=BitcoinABC_BitcoinAbcStaging 
TeamCity server version is 2019.2.4 (build 72059), server timezone: GMT (UTC)

[15:43:45]E: bt15 (running for 7s)
[15:43:45]i: TeamCity server version is 2019.2.4 (build 72059)
[15:43:45] : Collecting changes in 2 VCS roots
[15:43:45] :	 [Collecting changes in 2 VCS roots] VCS Root details
[15:43:45] :		 [VCS Root details] "phab-bitcoin-abc-staging-ro" {instance id=18, parent internal id=14, parent id=PhabBitcoinAbcStagingRo, description: "https://reviews.bitcoinabc.org/source/bitcoin-abc-staging.git#refs/heads/master"}
[15:43:45] :		 [VCS Root details] "abc-infrastructure" {instance id=7, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[15:43:47] : The build is removed from the queue to be prepared for the start
[15:43:52]W: This build has not been started because some of the builds it depends on failed to start
[15:43:52]E: Snapshot dependency "Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout" failed
[15:43:52] : Build finished