Differential D11199

[Cashtab] BalanceHeaderFiat component handles null value for fiatPrice
ClosedPublic
Actions

Authored by kieran709 on Mar 16 2022, 19:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC95587fe8f0d6: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice

Summary

Related to task T2314. Removed conditional logic from Send.js which handled rendering the BalanceHeaderFiat component and moved it into the BalanceFiat component.

Test Plan

cd web/cashtab
npm start
from the wallet tab, observe the BalanceHeaderFiat component.
ctrl + refresh the page, observe the BalanceHeaderFiat component render as the api fetches the fiatPrice.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

balance-header-handle-null-value

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18526
Build 36847: Build Diff	cashtab-tests
Build 36846: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 16 2022, 19:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2022, 19:56

kieran709 requested review of this revision.Mar 16 2022, 19:56

Harbormaster completed remote builds in B18526: Diff 32776.Mar 16 2022, 20:01

bytesofman requested changes to this revision.Mar 16 2022, 22:14

This revision now requires changes to proceed.Mar 16 2022, 22:14

bytesofman accepted this revision.Mar 16 2022, 23:18

This revision is now accepted and ready to land.Mar 16 2022, 23:18

Closed by commit rABC95587fe8f0d6: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice (authored by kieran709). · Explain WhyMar 17 2022, 14:38

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC95587fe8f0d6: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

BalanceHeaderFiat.js

39 lines

Home/

__tests__/

__snapshots__/

Home.test.js.snap

Send/

13 lines

__tests__/

__snapshots__/

Send.test.js.snap

Tokens/

__tests__/

__snapshots__/

Tokens.test.js.snap

Diff 32776

web/cashtab/src/components/Common/BalanceHeaderFiat.js

Loading...

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

Loading...

web/cashtab/src/components/Send/Send.js

Loading...

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

Loading...

web/cashtab/src/components/Tokens/tests/snapshots/Tokens.test.js.snap

Loading...