Related to task T2315. In Send.js, added checks for priceApiError to grey out send button if priceApiError is true, and another which hides LocaleFormattedValue if priceApiError is true. In EnhancedInputs.js, a disabled prop has been added which is used in Send.js to disable the amount input if priceApiError is true.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC82937429a224: [Cashtab] Improve handling of priceApiError in Send.js
cd web/cashtab && npm start
in useWallet.js, introduce a typo into the string to force an error msg
navigate the send tab
in the amount field, select the fiat currency from the dropdown menu
observe that the LocaleFormatted value does not appear
observe that the send button is greyed out
observe that the amount input is disabled
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- handle-price-api-error-on-send-screen
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18569 Build 36932: Build Diff cashtab-tests Build 36931: arc lint + arc unit
Event Timeline
| web/cashtab/src/components/Common/EnhancedInputs.js | ||
|---|---|---|
| 206 | Because disabled is already in the inputProps -- this line isn't doing anything. Delete. | |
| web/cashtab/src/components/Send/Send.js | ||
| 741 | Is this 'disabled' syntax used elsewhere in the app? Or is it in the antd docs? Not sure where this is coming from. The line should just be disabled: priceApiError, | |