Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0142e0e83a99: [Cashtab] Airdrop Option - ignore own address

Summary

Option to exclude the airdrop sender's address from the list of recipients.

Test Plan

npm start
ensure normal airdrop calculation is correct
tick the Ignore my own address option then ensure airdrop calculation excludes the active address, including the distribution ratio of XEC

Diff Detail

Repository

rABC Bitcoin ABC

Branch

airdropIgnoreOwnAddress

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18691
Build 37173: Build Diff	cashtab-tests
Build 37172: arc lint + arc unit

Event Timeline

emack created this revision.Mar 23 2022, 12:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2022, 12:10

emack requested review of this revision.Mar 23 2022, 12:10

Harbormaster completed remote builds in B18611: Diff 32911.Mar 23 2022, 12:14

emack mentioned this in D11259: [Cashtab] Airdrop Option - ignore eToken creator address.Mar 25 2022, 04:14

Rebased to Cashtab V2

Harbormaster completed remote builds in B18666: Diff 32984.Mar 30 2022, 06:06

bytesofman requested changes to this revision.Mar 30 2022, 16:48

bytesofman added inline comments.

web/cashtab/src/components/Airdrop/Airdrop.js
143 ↗	(On Diff #32984)	Is this step only required for the case where `ignoreOwnAddress` is true? If so, include this calc inside `if (ignoreOwnAddress)`
384 ↗	(On Diff #32984)	For a boolean setting, use a switch instead of a checkbox (I think better UX for mobile; this is what Cashtab does everywhere else).