Differential D1217

Simplify IsOpcodeDisabled
ClosedPublic
Actions

Authored by deadalnix on Mar 19 2018, 09:57.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING21f892e055c2: Simplify IsOpcodeDisabled
rABC21f892e055c2: Simplify IsOpcodeDisabled

Summary

Cyclomatic complexity goes from 27 to 17.

Also remove inline qualifier that is completely useless here.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

disabledsimplify

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2176
Build 2496: Bitcoin ABC Buildbot (legacy)
Build 2495: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 19 2018, 09:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2018, 09:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2176: Diff 3302!Mar 19 2018, 10:15

rebase

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2178: Diff 3305.Mar 19 2018, 11:16

jasonbcox accepted this revision.Mar 19 2018, 16:48

This revision is now accepted and ready to land.Mar 19 2018, 16:48

Closed by commit rABC21f892e055c2: Simplify IsOpcodeDisabled (authored by deadalnix). · Explain WhyMar 19 2018, 17:20

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

54 lines

Diff 3302

View Options

src/script/interpreter.cpp

Simplify IsOpcodeDisabledClosedPublicActions