refactor: return std::nullopt instead of {}
ClosedPublic
Actions

Authored by PiRK on Apr 5 2022, 09:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC078ea74aa186: refactor: return std::nullopt instead of {}

Summary

This is a backport of core#21498

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21498

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18728
Build 37247: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang · build-clang-tidy · build-debug · build-diff
Build 37246: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 5 2022, 09:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2022, 09:39

PiRK requested review of this revision.Apr 5 2022, 09:39

teamcity edited the summary of this revision. (Show Details)Apr 5 2022, 09:39

Fabien accepted this revision.Apr 5 2022, 09:50

This revision is now accepted and ready to land.Apr 5 2022, 09:50

Harbormaster completed remote builds in B18728: Diff 33066.Apr 5 2022, 09:54

Closed by commit rABC078ea74aa186: refactor: return std::nullopt instead of {} (authored by PiRK). · Explain WhyApr 6 2022, 06:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC078ea74aa186: refactor: return std::nullopt instead of {}.

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

2 lines

validation.cpp

2 lines

Diff 33066

View Options

src/txmempool.cpp