Ensure that CScriptNum is self contained.
ClosedPublic
Actions

Authored by deadalnix on Mar 19 2018, 13:02.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5727a061b7fc: Ensure that CScriptNum is self contained.
rABC5727a061b7fc: Ensure that CScriptNum is self contained.

Summary

CScriptNum is somewhat of a mess, so ensuring the mess is contained is good.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

scriptnumencoderefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2180
Build 2504: Bitcoin ABC Buildbot (legacy)
Build 2503: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 19 2018, 13:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2018, 13:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel accepted this revision.Mar 19 2018, 13:22

This revision is now accepted and ready to land.Mar 19 2018, 13:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2180: Diff 3307.Mar 19 2018, 13:23

Closed by commit rABC5727a061b7fc: Ensure that CScriptNum is self contained. (authored by deadalnix). · Explain WhyMar 19 2018, 13:46

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

script.h

15 lines

script.cpp

3 lines

test/

scriptnum_tests.cpp

4 lines

Diff 3307

View Options

src/script/script.h

View Options

src/script/script.cpp

View Options

src/test/scriptnum_tests.cpp

Ensure that CScriptNum is self contained.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3307

src/script/script.h

src/script/script.cpp

src/test/scriptnum_tests.cpp

Ensure that CScriptNum is self contained.
ClosedPublic
Actions

Revision Contents
Changeset List