Differential D11310

[Cashtab] Match seed phrase collapse title position
ClosedPublic
Actions

Authored by kieran709 on Apr 5 2022, 18:04.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCb8d8a531b05c: [Cashtab] Match seed phrase collapse title position

Summary

Related to task T2349. Text in seed phrase collapse should be centered in Configure.js

Test Plan

cd web/casthab && npm start
navigate to configure page
observe that the text in the seed phrase collapse is now centered

Diff Detail

Repository

rABC Bitcoin ABC

Branch

match-collapse-title-position-config

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18748
Build 37287: Build Diff	cashtab-tests
Build 37286: arc lint + arc unit

Event Timeline

kieran709 created this revision.Apr 5 2022, 18:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2022, 18:04

kieran709 requested review of this revision.Apr 5 2022, 18:04

Harbormaster completed remote builds in B18738: Diff 33081.Apr 5 2022, 18:07

bytesofman accepted this revision.Apr 5 2022, 21:09

This revision is now accepted and ready to land.Apr 5 2022, 21:09

rebase to master

Harbormaster completed remote builds in B18743: Diff 33089.Apr 5 2022, 22:14

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 5
+ Received  + 1

@@ -1,14 +1,10 @@
  <div
    className="sc-gqjmRU dYraLr"
  >
    <div
- <<<<<<< HEAD
-     className="sc-gipzik kiYvZB"
- =======
-     className="sc-csuQGl lmSVGz"
- >>>>>>> 2ab954cc3 ([Cashtab] Match seed phrase collapse title position)
+     className="sc-gipzik kgsCNX"
    >
      <h2>
        <span
          aria-label="copy"
          className="anticon anticon-copy sc-bdVaJa jyutTw"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:17:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 5
+ Received  + 1

@@ -1,14 +1,10 @@
  <div
    className="sc-gqjmRU dYraLr"
  >
    <div
- <<<<<<< HEAD
-     className="sc-gipzik kiYvZB"
- =======
-     className="sc-csuQGl lmSVGz"
- >>>>>>> 2ab954cc3 ([Cashtab] Match seed phrase collapse title position)
+     className="sc-gipzik kgsCNX"
    >
      <h2>
        <span
          aria-label="copy"
          className="anticon anticon-copy sc-bdVaJa jyutTw"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:31:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet