Page MenuHomePhabricator

[test] test regtest deterministic chain setup
ClosedPublic

Authored by PiRK on Apr 11 2022, 11:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC843a4eda7167: [test] test regtest deterministic chain setup
Summary

Reproduce the deterministic chain setup from D11225 as a functional test. This will make it possible to test the allowed assumeutxo hashes for REGTEST in D11238.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deterministic_chain
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18773
Build 37337: Build Diffbuild-without-wallet · build-clang-tidy · build-diff · build-clang · build-debug
Build 37336: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Apr 11 2022, 11:42

Move the hash conversion to int where it is needed, so that the tip can be directly checked against a hash in string format.

fix typehint after changing the type of the hash (solves the mypylinter error)

don't use parentheses for the assertion, use a copyright header whitelisted in contrib/devtools/copyright_header.py

This revision is now accepted and ready to land.Apr 11 2022, 15:58
This revision was automatically updated to reflect the committed changes.