Paths

Table of Contentst

Differential D11336

rpc, test: document {previous,next}blockhash as optional
ClosedPublic
Actions

Authored by PiRK on Apr 12 2022, 13:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC77d52b9d3c39: rpc, test: document {previous,next}blockhash as optional

Summary

Affects the following RPCs:

getblockheader
getblock

Also adds trivial tests on genesis block (should not contain "previousblockhash") and best block (should not contain "nextblockhash").

This is a backport of core#21053

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21114

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18794
Build 37379: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 37378: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 12 2022, 13:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2022, 13:40

PiRK requested review of this revision.Apr 12 2022, 13:40

teamcity edited the summary of this revision. (Show Details)Apr 12 2022, 13:40

Harbormaster completed remote builds in B18794: Diff 33173.Apr 12 2022, 13:54

Fabien accepted this revision.Apr 12 2022, 20:24

This revision is now accepted and ready to land.Apr 12 2022, 20:24

Closed by commit rABC77d52b9d3c39: rpc, test: document {previous,next}blockhash as optional (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyApr 13 2022, 18:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC77d52b9d3c39: rpc, test: document {previous,next}blockhash as optional.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

12 lines

test/

functional/

rpc_blockchain.py

8 lines

Diff 33173

View Options

src/rpc/blockchain.cpp