Paths

Table of Contentst

Differential D11342

[Cashtab] Export contact list
ClosedPublic
Actions

Authored by emack on Apr 13 2022, 02:17.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfbf44f39082b: [Cashtab] Export contact list

Summary

Supersedes D11321.

Contact export function.

Test Plan

open a wallet with an empty contact list and ensure the Export contacts button is not rendered
add a new contact, verify the Export contacts button is displayed and ensure clicking on this button results in a csv file being generated for download
add two more contacts and ensure the exported csv file shows each contact delimitered by a comma
test across browsers and extension/iOS/Android

Diff Detail

Repository

rABC Bitcoin ABC

Branch

exportContacts2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18803
Build 37397: Build Diff	cashtab-tests
Build 37396: arc lint + arc unit

Event Timeline

emack created this revision.Apr 13 2022, 02:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 02:17

emack requested review of this revision.Apr 13 2022, 02:17

emack mentioned this in D11321: [Cashtab] Export contact list.Apr 13 2022, 02:17

Harbormaster completed remote builds in B18803: Diff 33184.Apr 13 2022, 02:20

bytesofman requested changes to this revision.Apr 14 2022, 09:36

bytesofman added inline comments.

web/cashtab/src/components/Configure/Configure.js
1126	Use a styled `button` component instead of `<Link>`, as `<Link>` requires a `to` param

This revision now requires changes to proceed.Apr 14 2022, 09:36

Using styled button instead of Link

Harbormaster completed remote builds in B18826: Diff 33222.Apr 14 2022, 12:33

See feedback for 11345 -- use styled component instead of generic button

This revision now requires changes to proceed.Apr 20 2022, 17:14

Updates to contact list button as a styled component

Harbormaster completed remote builds in B18856: Diff 33269.Apr 21 2022, 11:20

bytesofman accepted this revision.Apr 21 2022, 22:40

This revision is now accepted and ready to land.Apr 21 2022, 22:40

Closed by commit rABCfbf44f39082b: [Cashtab] Export contact list (authored by emack). · Explain WhyApr 21 2022, 23:03

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCfbf44f39082b: [Cashtab] Export contact list.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Configure/

70 lines

__tests__/

__snapshots__/

Configure.test.js.snap

Diff 33184

web/cashtab/src/components/Configure/Configure.js

Loading...

web/cashtab/src/components/Configure/tests/snapshots/Configure.test.js.snap

Loading...