Page MenuHomePhabricator
Differential D1221

Refactor opcode test to reduce redundancy
ClosedPublic
Actions

Authored by deadalnix on Mar 19 2018, 17:39.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2bdf00a68097: Refactor opcode test to reduce redundancy
rABC2bdf00a68097: Refactor opcode test to reduce redundancy
Summary

This will ensure that newly created tests will test all the flags painlessly.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 19 2018, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2018, 17:39
jasonbcox added a subscriber: jasonbcox.Mar 19 2018, 17:42
jasonbcox added inline comments.
src/test/monolith_opcodes.cpp
372 ↗(On Diff #3317)

cocnversion -> conversion

deadalnix updated this revision to Diff 3318.Mar 19 2018, 17:48

Fix typo

jasonbcox accepted this revision.Mar 19 2018, 17:49
This revision is now accepted and ready to land.Mar 19 2018, 17:49
Closed by commit rABC2bdf00a68097: Refactor opcode test to reduce redundancy (authored by deadalnix). · Explain WhyMar 19 2018, 17:49
This revision was automatically updated to reflect the committed changes.
teamcity added a subscriber: teamcity.Mar 19 2018, 18:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 19 2018, 18:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 19 2018, 18:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2186: Diff 3317.Mar 19 2018, 18:30
teamcity added a comment.Mar 19 2018, 18:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2187: Diff 3318.Mar 19 2018, 18:39

Revision Contents
Changeset List

PathSize
src/
test/
120 lines

Diff 3319

View Options

src/test/monolith_opcodes.cpp

Loading...